fix(sdk): safari rendering #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusps
requested review from
renatamottam and
renatomaurovtex
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
renatomaurovtex
approved these changes
Jan 28, 2025
gabpaladino
reviewed
Jan 28, 2025
| if (window.requestIdleCallback) { | ||
| window.requestIdleCallback(callback) | ||
| } else { | ||
| window.setTimeout(callback, 1) |
There was a problem hiding this comment.
rapaz, o que exatamenta essa logica de verificar se esta idle faz?
me assustei uma vez com setTimeout de 1 no SF e agora me daparo com isso de novo kkkk
There was a problem hiding this comment.
There was a problem hiding this comment.
- mesmo problema: requestIdleCallback not available in Safari remix-run/indie-stack#124
- mesmo fix, inclusive: fix: Fallback to setTimeout if rIC isn't available remix-run/indie-stack#125
There was a problem hiding this comment.
não precisamos de uma solução mais sofisticada conforme o shim do link?
gvc
approved these changes
Jan 28, 2025
pedromtec
approved these changes
Jan 28, 2025
lucasfp13
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
requestIdleCallbackis not available in Safari.